----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/776/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Incorporated some remarks from the previous review. Probably still needs some touches. Comments welcome.
Diffs -----
openlmi-mof-register.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/776/diff/
Testing -------
Thanks,
Tomas Smetana
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/776/#review1033 -----------------------------------------------------------
Ship it!
openlmi-mof-register.py http://reviewboard-openlmi.rhcloud.com/r/776/#comment565
This is vulnerable to SQL injection. Although it's not really a risk in this case.
Looks good to me, ship it.
- Radek Novacek
On Aug. 30, 2013, 11:08 a.m., Tomas Smetana wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/776/
(Updated Aug. 30, 2013, 11:08 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Incorporated some remarks from the previous review. Probably still needs some touches. Comments welcome.
Diffs
openlmi-mof-register.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/776/diff/
Testing
Thanks,
Tomas Smetana
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/776/ -----------------------------------------------------------
(Updated Sept. 2, 2013, 9:27 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Incorporated some remarks from the previous review. Probably still needs some touches. Comments welcome.
Diffs -----
openlmi-mof-register.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/776/diff/
Testing -------
Thanks,
Tomas Smetana
openlmi-reviews@lists.fedorahosted.org