----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.
Diffs -----
cli/lmi/shell/LMIConstantValues.py 6e564ac413f3fbcb0afc3a8406b55d7701a3ab71 cli/lmi/shell/LMIUtil.py 5954b9650f358e53fb75e08d9aac30365be8964f
Diff: http://reviewboard-openlmi.rhcloud.com/r/701/diff/
Testing -------
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/#review896 -----------------------------------------------------------
cli/lmi/shell/LMIUtil.py http://reviewboard-openlmi.rhcloud.com/r/701/#comment480
Shouldn't it be like: ... cast[t.lower()] if t.lower() in cast ...
This way it checks if lowercased t is key in the dict but it gets non-lowercased key.
- Radek Novacek
On Aug. 9, 2013, 9:53 a.m., Peter Hatina wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/
(Updated Aug. 9, 2013, 9:53 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.
Diffs
cli/lmi/shell/LMIConstantValues.py 6e564ac413f3fbcb0afc3a8406b55d7701a3ab71 cli/lmi/shell/LMIUtil.py 5954b9650f358e53fb75e08d9aac30365be8964f
Diff: http://reviewboard-openlmi.rhcloud.com/r/701/diff/
Testing
Thanks,
Peter Hatina
On Aug. 9, 2013, 8:03 a.m., Radek Novacek wrote:
cli/lmi/shell/LMIUtil.py, line 136 http://reviewboard-openlmi.rhcloud.com/r/701/diff/2/?file=3956#file3956line136
Shouldn't it be like: ... cast[t.lower()] if t.lower() in cast ... This way it checks if lowercased t is key in the dict but it gets non-lowercased key.
Yes, I will fix that.
- Peter
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/#review896 -----------------------------------------------------------
On Aug. 9, 2013, 7:53 a.m., Peter Hatina wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/
(Updated Aug. 9, 2013, 7:53 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.
Diffs
cli/lmi/shell/LMIConstantValues.py 6e564ac413f3fbcb0afc3a8406b55d7701a3ab71 cli/lmi/shell/LMIUtil.py 5954b9650f358e53fb75e08d9aac30365be8964f
Diff: http://reviewboard-openlmi.rhcloud.com/r/701/diff/
Testing
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/ -----------------------------------------------------------
(Updated Aug. 9, 2013, 8:08 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.
Diffs (updated) -----
cli/lmi/shell/LMIUtil.py 5954b9650f358e53fb75e08d9aac30365be8964f cli/lmi/shell/LMIConstantValues.py 6e564ac413f3fbcb0afc3a8406b55d7701a3ab71
Diff: http://reviewboard-openlmi.rhcloud.com/r/701/diff/
Testing -------
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/#review898 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On Aug. 9, 2013, 10:08 a.m., Peter Hatina wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/
(Updated Aug. 9, 2013, 10:08 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.
Diffs
cli/lmi/shell/LMIUtil.py 5954b9650f358e53fb75e08d9aac30365be8964f cli/lmi/shell/LMIConstantValues.py 6e564ac413f3fbcb0afc3a8406b55d7701a3ab71
Diff: http://reviewboard-openlmi.rhcloud.com/r/701/diff/
Testing
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/ -----------------------------------------------------------
(Updated Sept. 19, 2013, 1:16 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.
Diffs -----
cli/lmi/shell/LMIUtil.py 5954b9650f358e53fb75e08d9aac30365be8964f cli/lmi/shell/LMIConstantValues.py 6e564ac413f3fbcb0afc3a8406b55d7701a3ab71
Diff: http://reviewboard-openlmi.rhcloud.com/r/701/diff/
Testing -------
Thanks,
Peter Hatina
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher