----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1182/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
accept shell abstractions besides cim types
Allow callers to pass lmi shell wrappers where just cim types were expected. Both LMIInstance(Name) and CIMInstance(Name) objects represent the same thing, be benevolent on input and treat them the same way.
Diffs -----
cli/lmi/shell/LMIMethod.py f17e16946786b8cef6fedca972f4c4a378ee8675 cli/lmi/shell/LMIInstance.py 864e9c2ad7d37d89d85094ac84ad8bac5321e596 cli/lmi/shell/LMIInstanceName.py d88e630b160edbb2fe5799afe60bcefd11903199 cli/lmi/shell/LMIClass.py ae7be66646442c20e3c8583b0b492130dafe6d45 cli/lmi/shell/LMIBaseClient.py 745e487d9ccf619e6428f1b87ec52f615b125f22
Diff: http://reviewboard-openlmi.rhcloud.com/r/1182/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1182/#review1608 -----------------------------------------------------------
Ship it!
Ship It!
- Peter Hatina
On Nov. 2, 2013, 11:49 a.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1182/
(Updated Nov. 2, 2013, 11:49 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
accept shell abstractions besides cim types
Allow callers to pass lmi shell wrappers where just cim types were expected. Both LMIInstance(Name) and CIMInstance(Name) objects represent the same thing, be benevolent on input and treat them the same way.
Diffs
cli/lmi/shell/LMIMethod.py f17e16946786b8cef6fedca972f4c4a378ee8675 cli/lmi/shell/LMIInstance.py 864e9c2ad7d37d89d85094ac84ad8bac5321e596 cli/lmi/shell/LMIInstanceName.py d88e630b160edbb2fe5799afe60bcefd11903199 cli/lmi/shell/LMIClass.py ae7be66646442c20e3c8583b0b492130dafe6d45 cli/lmi/shell/LMIBaseClient.py 745e487d9ccf619e6428f1b87ec52f615b125f22
Diff: http://reviewboard-openlmi.rhcloud.com/r/1182/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1182/ -----------------------------------------------------------
(Updated Nov. 4, 2013, 9:24 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
accept shell abstractions besides cim types
Allow callers to pass lmi shell wrappers where just cim types were expected. Both LMIInstance(Name) and CIMInstance(Name) objects represent the same thing, be benevolent on input and treat them the same way.
Diffs -----
cli/lmi/shell/LMIMethod.py f17e16946786b8cef6fedca972f4c4a378ee8675 cli/lmi/shell/LMIInstance.py 864e9c2ad7d37d89d85094ac84ad8bac5321e596 cli/lmi/shell/LMIInstanceName.py d88e630b160edbb2fe5799afe60bcefd11903199 cli/lmi/shell/LMIClass.py ae7be66646442c20e3c8583b0b492130dafe6d45 cli/lmi/shell/LMIBaseClient.py 745e487d9ccf619e6428f1b87ec52f615b125f22
Diff: http://reviewboard-openlmi.rhcloud.com/r/1182/diff/
Testing -------
Thanks,
Michal Minar
openlmi-reviews@lists.fedorahosted.org