January 2019 - package-review - Fedora Mailing-Lists

[Bug 1662538] New: Review Request: python-tvb-data - Demo data for The Virtual Brain software

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1662538 Bug ID: 1662538 Summary: Review Request: python-tvb-data - Demo data for The Virtual Brain software Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: sanjay.ankur(a)gmail.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://ankursinha.fedorapeople.org/python-tvb-data/python-tvb-data.spec SRPM URL: https://ankursinha.fedorapeople.org/python-tvb-data/python-tvb-data-1.5.6... Description: The Virtual Brain Project (TVB Project) has the purpose of offering some modern tools to the Neurosciences community, for computing, simulating and analyzing functional and structural data of human brains. Various demonstration datasets for use with The Virtual Brain are provided here. Fedora Account System Username: ankursinha rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=31716759 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
19
0 / 0

[Bug 1663708] New: Review Request: golang-github-jawher-mow-cli - Versatile library for building CLI applications in Go

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1663708 Bug ID: 1663708 Summary: Review Request: golang-github-jawher-mow-cli - Versatile library for building CLI applications in Go Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: carl(a)george.computer QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/go/fedora-raw... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/go/fedora-raw... Description: Versatile library for building CLI applications in Go. Fedora Account System Username: carlwgeorge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
10
0 / 0

[Bug 1667174] New: Review Request: console-login-helper-messages - Shows helper information in terminal before/after login

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1667174 Bug ID: 1667174 Summary: Review Request: console-login-helper-messages - Shows helper information in terminal before/after login Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody(a)fedoraproject.org Reporter: rfairley(a)redhat.com QA Contact: extras-qa(a)fedoraproject.org CC: package-review(a)lists.fedoraproject.org Target Milestone: --- Classification: Fedora Spec URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/console-login-he... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rfairley/console-login-he... Description: Combines motd, issue, profile features to show system information to the user before/on login. The information shown before login (via issue) includes: SSH keys, and an IP address to use for SSH login. Information shown at login is a brief MOTD with system information sourced from `/etc/os-release`. A profile script that shows failed systemd units upon login to the bash terminal is also included. Fedora Account System Username: rfairley Hi! I have packaged console-login-helper-messages (upstream: https://github.com/rfairley/console-login-helper-messages) for distribution in Fedora. I am the upstream maintainer for this package. The need for console-login-helper-messages this arose from https://github.com/coreos/fedora-coreos-tracker/issues/36#issue-354763917 to carry forward information shown at the login prompt on Container Linux to Fedora CoreOS. We think the console messages could be helpful for similar systems that might only have the serial console available before login, and can display the IP address/SSH keys before logging in through SSH. This is my first package, and I will need a sponsor. Past contributions in Fedora I have made include adding the option of displaying MOTD messages from other directories, and helping patching these changes to Fedora. Upstream issue: https://github.com/linux-pam/linux-pam/issues/68. Fedora patches: * https://src.fedoraproject.org/rpms/pam/pull-request/5. * https://github.com/fedora-selinux/selinux-policy/pull/232 * https://pagure.io/setup/pull-request/15 Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=32090526 A few ways to verify the package works if reviewing: https://github.com/rfairley/console-login-helper-messages/blob/master/rev... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
7
0 / 0

[Bug 1636111] Review Request: glyr - Glyr is a music related metadata searchengine

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1636111 --- Comment #40 from Mukundan Ragavan <nonamedotc(a)gmail.com> --- I have now sponsored you. Welcome to packager group. Submit SCM request using fedpkg. Here is the syntax fedpkg request-repo <package-name> 12345 For help, consult fedpkg request-repo --help -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
0
0 / 0

[Bug 1636111] Review Request: glyr - Glyr is a music related metadata searchengine

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1636111 Mukundan Ragavan <nonamedotc(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #39 from Mukundan Ragavan <nonamedotc(a)gmail.com> --- Package approved. I will sponsor you. Permissions should propagate through the account system shortly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
0
0 / 0

[Bug 1636111] Review Request: glyr - Glyr is a music related metadata searchengine

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1636111 --- Comment #38 from Mukundan Ragavan <nonamedotc(a)gmail.com> --- Very nice! $ diff -Nu 1636111-glyr/srpm-unpacked/glyr.spec glyr.spec --- 1636111-glyr/srpm-unpacked/glyr.spec 2019-01-30 20:23:43.383129623 -0500 +++ glyr.spec 2019-01-30 06:37:14.000000000 -0500 @@ -9,7 +9,7 @@ Name: glyr Version: 1.0.10 -Release: 10%{?git_version:.%{?git_version}}%{?dist} +Release: 11%{?git_version:.%{?git_version}}%{?dist} Summary: Search engine for music related metadata # Source0 was generated as follows: @@ -75,12 +75,12 @@ %patch2 -p1 %build -%{cmake} -DTEST=true -DCMAKE_BUILD_TYPE=RelWithDebInfo +%{cmake} -DTEST=true -DCMAKE_BUILD_TYPE=RelWithDebInfo . %make_build %check bin/check_api -bin/check_dbc +CK_TIMEOUT_MULTIPLIER=20 bin/check_dbc # This check fails so ignore that # bin/check_opt @@ -103,6 +103,9 @@ %changelog +* Wed Jan 30 2019 Matias De lellis <mati86dl(a)gmail.com> - 1.0.10-11.20180824git618c418e +- Increase timeout in test, and add construction directory in cmake. + * Thu Nov 08 2018 Matias De lellis <mati86dl(a)gmail.com> - 1.0.10-10.20180824git618c418e - Add a patch that disables test that depends on internet connection. Scratch build works fine. https://koji.fedoraproject.org/koji/taskinfo?taskID=32351660 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
0
0 / 0

[Bug 1659286] Review Request: python-openshift - Python client for the OpenShift API

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1659286 --- Comment #16 from Jason Tibbitts <tibbs(a)math.uh.edu> --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-openshift -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
0
0 / 0

[Bug 1659286] Review Request: python-openshift - Python client for the OpenShift API

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1659286 Jason Montleon <jmontleo(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dmellado(a)redhat.com |amoralej(a)redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
0
0 / 0

[Bug 1659286] Review Request: python-openshift - Python client for the OpenShift API

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1659286 Alfredo Moralejo <amoralej(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #15 from Alfredo Moralejo <amoralej(a)redhat.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated", "Apache License (v2.0)". 818 files have unknown license. Detailed output of licensecheck in /tmp/1659286-python- openshift/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-openshift , python-openshift-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-openshift-0.8.4-2.fc30.noarch.rpm python-openshift-doc-0.8.4-2.fc30.noarch.rpm python-openshift-0.8.4-2.fc30.src.rpm python3-openshift.noarch: W: no-documentation python3-openshift.noarch: E: wrong-script-interpreter /usr/lib/python3.7/site-packages/openshift/dynamic/client.py /usr/bin/env python python3-openshift.noarch: E: non-executable-script /usr/lib/python3.7/site-packages/openshift/dynamic/client.py 644 /usr/bin/env python python3-openshift.noarch: W: no-manual-page-for-binary openshift-ansible-gen python-openshift-doc.noarch: W: summary-ended-with-dot C Documentation for python-openshift. 3 packages and 0 specfiles checked; 2 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python-openshift-doc (rpmlib, GLIBC filtered): python3-openshift (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3 python3-dictdiffer python3-jinja2 python3-kubernetes python3-requests python3-ruamel-yaml python3-six python3-string_utils python3.7dist(dictdiffer) python3.7dist(jinja2) python3.7dist(kubernetes) python3.7dist(python-string-utils) python3.7dist(ruamel.yaml) python3.7dist(six) Provides -------- python-openshift-doc: python-openshift-doc python3-openshift: python3-openshift python3.7dist(openshift) python3dist(openshift) Source checksums ---------------- https://github.com/openshift/openshift-restclient-python/archive/v0.8.4.t... : CHECKSUM(SHA256) this package : 0a2a19953a766aead72ab1cc01432be7d0b54c8ed6303f068bb68b3da7231d0d CHECKSUM(SHA256) upstream package : 0a2a19953a766aead72ab1cc01432be7d0b54c8ed6303f068bb68b3da7231d0d Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1659286 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Notes: - About shebang issue in openshift/dynamic/client.py , it has been fixed upstream but not released yet so it will be fixed in new release. Package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
0
0 / 0

[Bug 1659286] Review Request: python-openshift - Python client for the OpenShift API

by bugzilla＠redhat.com

https://bugzilla.redhat.com/show_bug.cgi?id=1659286 --- Comment #14 from Alfredo Moralejo <amoralej(a)redhat.com> --- (In reply to Jason Montleon from comment #13) > I think the missing deps for tests were bdd and kubernetes. We have > kubernetes now and we don't need bdd for unit tests. > > So I've added unit tests, removed the /* to stop orphaning the dirs, and > cleaned up the sed for EL7. > > http://people.redhat.com/jmontleo/pk-epel/python-openshift.spec > http://people.redhat.com/jmontleo/pk-epel/python-openshift-0.8.4-2.fc29.src. > rpm Thanks for all those fixes. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

5 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review January 2019