[Bug 1658199] Review Request: netatalk - Open Source Apple Filing
Protocol(AFP) File Server
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1658199
--- Comment #18 from Andrew Bauer <zonexpertconsulting(a)outlook.com> ---
Scott - Thank you very much to taking on this review. I was beginning to wonder
what creative posts I might need to come up with on the devel list, funny
jokes, recent declaration of independence, etc to persuade someone to review
this for me. I owe you one, should you ever need me to review one of your
requests.
> %global _hardened_build 1
> This shouldn't be needed in Fedora anymore
Agreed. I have this included because I plan to build for el7, and hardened
builds default to off.
> Source0: http://download.sourceforge.net/netatalk/netatalk-%{version}.tar.bz2
> Use https.
Will do.
> BuildRequires: rpm
> I don't think you need to BuildRequire rpm.
Take a look at the pkgver and xslver macros. They call the rpm binary. While
I'd call these macros unusual in the way they are created, these predate my
involvement so I left them alone. If there is a prettier way to go about
creating these macros, I'm certainly willing to look into it.
> Requires: %{name}%{?_isa} = %{version}
> I think you need to include the epoch here.
You are absolutely right. I forgot the modify this line when I put epoch back
in.
I am out of town for my dayjob all week this week. I will add these action
items to my to-do list when I return home. Thanks again for taking on this
review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 4 months
[Bug 1636111] Review Request: glyr - Glyr is a music related
metadata searchengine
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1636111
--- Comment #34 from Matias De lellis <mati86dl(a)gmail.com> ---
Hi Mukundan,
I was on vacation, now I take it back...
ppc64le:
-
/builddir/build/BUILD/glyr/spec/capi/check_dbc.c:110:E:DBCache:test_iter_db:0:
(after this point) Test timeout expired
aarch64:
-
/builddir/build/BUILD/glyr/spec/capi/check_dbc.c:110:E:DBCache:test_iter_db:0:
(after this point) Test timeout expired
armv7hl:
-
/builddir/build/BUILD/glyr/spec/capi/check_dbc.c:110:E:DBCache:test_iter_db:0:
(after this point) Test timeout expired
The three compilations failed on test due to the same problem. :disapointed:
It seems just a temp problem, because in the correct compilations, this test
was executed and passed .. Can you try again?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 4 months
[Bug 1481630] Review Request: virtualbox-guest-additions -
VirtualBox Guest Additions
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1481630
--- Comment #90 from Hans de Goede <hdegoede(a)redhat.com> ---
(In reply to Sergio Monteiro Basto from comment #89)
> Hi , thanks for the reply , another question, can we use new vboxsf source
> [1] in el7 ?
>
> i.e. instead use new vboxsf source [1] code only in F28+ [2], can I use it
> for all cases (el7 and old F27 for example ) ?
No, the new vboxsf sources rely on the upstreamed vboxguest driver which
is not in the RHEL7 / F27 kernels.
> BTW in vboxsf-master/super.c line 153 if (flags & MS_REMOUNT) FTBFS with
> kernel 5.0.0-rc3 , I'm testing add this [3] to source code , based on [4]
I've fixed this myself by simply dropping the 2 lines, the VFS core already
does this check, so it is not necessary. I've just pushed this change to:
https://github.com/jwrdegoede/vboxsf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 4 months
[Bug 1658199] Review Request: netatalk - Open Source Apple Filing
Protocol(AFP) File Server
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1658199
--- Comment #17 from Scott Talbert <swt(a)techie.net> ---
> %package devel
> Summary: Development files for %{name}
> Requires: %{name}%{?_isa} = %{version}
I think you need to include the epoch here. I think this is causing this
rpmlint warning:
netatalk-devel.x86_64: W: incoherent-version-dependency-on
netatalk/netatalk-libs/libnetatalk 3.1.12 5:3.1.12
Also, the package is building fine but fails to install. I haven't looked into
why exactly, but do you see that problem?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 4 months