https://bugzilla.redhat.com/show_bug.cgi?id=1690046
--- Comment #3 from jogas(a)lanl.gov ---
(In reply to Dave Love from comment #2)
I didn't realize this would need sponsorship as well as review.
Anyway, it needs work. The first requirement is to build, which it doesn't
on
rawhide, at least. You should do scratch builds, taking into account
the differences between el7 and rawhide. There are various other
things that need fixing which I haven't got time for immediately, but
have a look at
https://copr-dist-git.fedorainfracloud.org/cgit/loveshack/charliecloud/
charliecloud.git/tree/
in comparison. I'm not sure of the merits of shipping the test files,
but they should be in a separate package -- they're not documentation
-- and all you need to avoid the issue of compiling with the wrong
python cleanly is to define the right one, and you need versioned
python now.
(In reply to Dave Love from comment #2)
I didn't realize this would need sponsorship as well as review.
Anyway, it needs work. The first requirement is to build, which it doesn't
on
rawhide, at least. You should do scratch builds, taking into account
the differences between el7 and rawhide. There are various other
things that need fixing which I haven't got time for immediately, but
have a look at
https://copr-dist-git.fedorainfracloud.org/cgit/loveshack/charliecloud/
charliecloud.git/tree/
in comparison. I'm not sure of the merits of shipping the test files,
but they should be in a separate package -- they're not documentation
-- and all you need to avoid the issue of compiling with the wrong
python cleanly is to define the right one, and you need versioned
python now.
Dave,
I appreciate you taking the time to review and point out issues that need
resolving in such a timely manner. Thank you. We recently updated the
charliecloud build procedure in an effort to reduce packaging complexity. I am
working on incorporating some of the technique and best practices I see in your
spec file. How would you like to be credited?
Best,
Jordan
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component