https://bugzilla.redhat.com/show_bug.cgi?id=2101769
--- Comment #3 from Timothy Redaelli <tredaelli(a)redhat.com> ---
(In reply to Neal Gompa from comment #2)
> Source0:
https://github.com/intel/pf-bb-config/archive/refs/tags/v%{version}.tar.g...
This should be simplified to the following:
"%{url}/archive/v%{version}/pf-bb-config-%{version}.tar.gz"
You're also missing "BuildRequires: make"
> %{_bindir}/*
> %{_datadir}/*
This is not specific enough.
Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
I updated the spec file and the srpm with the required modifications and, in
the meanwhile, I also rebased it with the last upstream version.
I hope it's ok now
Spec URL:
https://tredaell.fedorapeople.org/pf-bb-config/pf-bb-config.spec
SRPM URL:
https://tredaell.fedorapeople.org/pf-bb-config/pf-bb-config-22.07-1.fc38....
Thank you for your review
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2101769