https://bugzilla.redhat.com/show_bug.cgi?id=1268742
--- Comment #6 from Roman Joost <rjoost(a)redhat.com> ---
Diff against the old review:
--- ../1268742-rubygem-bacon-colored_output_old/review.txt 2017-07-28
09:46:15.738517634 +1000
+++ review.txt 2017-07-31 10:37:06.139563839 +1000
@@ -74,6 +74,17 @@
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
+Ruby:
+[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
+ independent under %{gem_dir}.
+[x]: Gem package must not define a non-gem subpackage
+[x]: Macro %{gem_extdir} is deprecated.
+[x]: Gem package is named rubygem-%{gem_name}
+[x]: Package contains BuildRequires: rubygems-devel.
+[x]: Gem package must define %{gem_name} macro.
+[x]: Pure Ruby package must be built as noarch
+[x]: Package does not contain Requires: ruby(abi).
+
===== SHOULD items =====
Generic:
@@ -86,7 +97,7 @@
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem-
bacon-colored_output-doc
[x]: Package functions as described.
-[!]: Latest version is packaged.
+[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
@@ -122,9 +133,9 @@
Rpmlint
-------
-Checking: rubygem-bacon-colored_output-1.0.1-2.fc25.noarch.rpm
- rubygem-bacon-colored_output-doc-1.0.1-2.fc25.noarch.rpm
- rubygem-bacon-colored_output-1.0.1-2.fc25.src.rpm
+Checking: rubygem-bacon-colored_output-1.1.1-1.fc25.noarch.rpm
+ rubygem-bacon-colored_output-doc-1.1.1-1.fc25.noarch.rpm
+ rubygem-bacon-colored_output-1.1.1-1.fc25.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
@@ -160,14 +171,14 @@
Source checksums
----------------
-https://rubygems.org/gems/bacon-colored_output-1.0.1.gem :
- CHECKSUM(SHA256) this package :
94653ad17450868ceb8d8154d516ce9201637388a0edfcd6f6b80372bfc18146
- CHECKSUM(SHA256) upstream package :
94653ad17450868ceb8d8154d516ce9201637388a0edfcd6f6b80372bfc18146
+https://rubygems.org/gems/bacon-colored_output-1.1.1.gem :
+ CHECKSUM(SHA256) this package :
fde2b3ec8f42cf0a8b2597bc625b20d5af88d08d9fcc715370953637f780defe
+ CHECKSUM(SHA256) upstream package :
fde2b3ec8f42cf0a8b2597bc625b20d5af88d08d9fcc715370953637f780defe
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/bin/fedora-review -b 1268742
Buildroot used: fedora-25-x86_64
-Active plugins: Generic, Shell-api
+Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component