Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752829
--- Comment #20 from Steve Traylen <steve.traylen(a)cern.ch> 2011-12-19 10:48:01 EST
---
Very nearly there:
(1)
It's best to change
%{_mandir}/man1/glue-validator.1.gz
%{_mandir}/man1/glue-validator.1*
to allow for different (or no) compression mechanisms, the actual mechanism
being defined outside
the .spec file. It may well change one day.
(2)
You still use both the new style '%{buildroot}' and the old style
$RPM_BUILD_ROOT.
Be consistant but my tip is to just drop $RPM_BUILD_ROOT completly in favour
of %{buildroot} always.
http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot....
(3)
Readability, you have blank line between %prep, %build and %install which is
probably
good but not between %install and %clean.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.