[Bug 436777] Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-tgcaptcha - A TurboGears CAPTCHA widget for forms https://bugzilla.redhat.com/show_bug.cgi?id=436777 panemade(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade(a)gmail.com 2008-03-12 03:14 EST ------- Review: + package builds in mock. koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=512432 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 08e52f7055d2f1084d225d910f637420 TGCaptcha-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. Also, 1)remove BR:python as python-devel anyway pulls it. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.