Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=802050
--- Comment #7 from Jeremy Newton <alexjnewt(a)hotmail.com> 2012-03-28 22:02:50 EDT
---
(In reply to comment #6)
(In reply to comment #3)
> Good point, this is another thing I can send upstream. Although knowing the
> current development, it probably won't be incorporated until 0.8 comes out.
Good enough. Please keep informing us about the progress. I think there is some
guideline about upstreaming patches. here it is
http://fedoraproject.org/wiki/Staying_close_to_upstream_projects
Yep, I included the bug reports right into the new spec :)
round 2:
-please use the %name macro whenever possible throughout the spec file i.e. in
the top section
-"make %{?_smp_mflags} install DESTDIR=%{buildroot}"
smp_mflags macro seems to be unnecessary since here no compilation is involved
-there is a typo in changelog 2
Done! Here's the new files and I also made a man page, which I sent upstream
(issue 405, see spec):
SPEC:
http://dl.dropbox.com/u/42480493/love.spec
SRPM:
http://dl.dropbox.com/u/42480493/love-0.7.2-3.fc16.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.