https://bugzilla.redhat.com/show_bug.cgi?id=1876864
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
Flags| |needinfo?(fedora(a)svgames.pl
| |)
--- Comment #5 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
Finishing this review or do you need help?
- Use libdir here too:
-DHDF5_LIB_PATH:PATH=/usr/lib \
-DHDF5_LIB_PATH:PATH=%{_libdir} \
- %{_builddir}/%{name}-%{version} is not needed here, at each stage, prep
build and install, you are cd to this directory, so you can use CMakeLists.txt
and . directly:
%{_builddir}/%{name}-%{version}/CMakeLists.txt
%cmake
[…]
%{_builddir}/%{name}-%{version}
- In order to avoid untintentional SONAME bump, we recommend not globbing the
major soname version in library. Be more specific instead:
%{_libdir}/libkea.so.1*
- You must install the LICENSE.txt with %license in %files
- You should provide README.md with %doc in %files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component