https://bugzilla.redhat.com/show_bug.cgi?id=2107842
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mhroncok(a)redhat.com
--- Comment #2 from Miro Hrončok <mhroncok(a)redhat.com> ---
Spec sanity:
%global pypi_name whatthepatch
%global pypi_version 1.0.2
In my opinion, defining this on top makes the spec file harder to read later,
albeit that is my opinionated view.
%global _description ...
Defining his at the top is a bit untraditional, I would very much prefer if you
stick to the order in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_exampl...
but again, that is my opinionated view.
BuildRequires: pyproject-rpm-macros
This is not necessary as the macros are pulled by python3-devel. However, it is
not forbidden.
BuildRequires: python3dist(setuptools)
This should not be necessary, as the build backend is BuildRequired by
%pyproject_buildrequires. Manual dependencies, when otherwise generated, SHOULD
not be used.
%{?python_provide:%python_provide python3-%{pypi_name}}
This is deprecated and SHOULD not be used.
%description -n python3-%{pypi_name}
%_description
I suppose this puts an extra empty line at the beginning of the description,
which is probably undesired.
%pyproject_buildrequires -x all,test
I see no all or test extras in this software. Please verify this.
%files -n python3-%{pypi_name}
%license LICENSE
%doc README.rst
%{python3_sitelib}/%{pypi_name}
%{python3_sitelib}/%{pypi_name}-%{pypi_version}.dist-info
Consider using %pyproject_save_files and %{pyproject_files}? However, that
remains optional.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2107842