https://bugzilla.redhat.com/show_bug.cgi?id=2017119
--- Comment #1 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Hello Graham,
thank you for adding this package.
Please specify the actual download URLs. It will help
fedora-review tool to automatically download them, and make the review
easier. In the case of the SRPM file, you can go to the project you linked,
open the detail of your last build and scroll down to the
"Results" section. Once you open fedora-rawhide-x86_64, there is a
directory listing where you can find the actual download URL. There is
also a spec file next to it, if you want to link spec file from Copr
as well.
In general, there is no problem with linking a spec file from GitHub
but please use the "Raw" link. Also, you are linking retry.spec.in
which still needs to be processed somehow to generate the actual
retry.spec. If you don't want to have a generated spec in the repo, my
recommendation is to simply use the spec file from Copr.
Group: Applications/System
Please remove the Group line, it is deprecated.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sect...
Source:
Sources should be indexed from zero, so please change Source: to
Source0:
Also, according to
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git...
I would recommend the following URL
https://github.com/minfrin/retry/archive/%{name}-%{version}/%{name}-%{ver...
or even
%{URL}/archive/%{name}-%{version}/%{name}-%{version}.tar.gz
if you swap URL: and Source0: lines, so the URL is defined first.
BuildRequires: gcc, autoconf, automake, libtool
While this is correct, I would recommend
BuildRequires: gcc
BuildRequires: autoconf
BuildRequires: automake
BuildRequires: libtool
Once you start adding and removing dependencies, it will be much
easier to read the diffs. But it's up to your preference.
%description
Retry has such a good help page, it would be a pity to not use
it. What about using the whole DESCRIPTION text from `retry --help`?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2017119