[Bug 1702720] Review Request: frr - routing daemon

https://bugzilla.redhat.com/show_bug.cgi?id=1702720 Martin Osvald 🛹 <mosvald(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mruprich(a)redhat.c | |om) --- Comment #13 from Martin Osvald 🛹 <mosvald(a)redhat.com&gt; --- It probably got overlooked in my messy comment 9 as it contained several issues mentioned close together so it probably got overlooked: - frr is not system group (-r) even it owns files under /{etc,run,var/log}/frr: ~~~ $ grep non-standard ~/review-frr/review.txt frr.x86_64: W: non-standard-uid /etc/frr frr frr.x86_64: W: non-standard-gid /etc/frr frr frr.x86_64: W: non-standard-uid /run/frr frr frr.x86_64: W: non-standard-gid /run/frr frr frr.x86_64: W: non-standard-uid /var/log/frr frr frr.x86_64: W: non-standard-gid /var/log/frr frr $ ~~~ While the above warnings don't directly relate to the missing '-r' option, but to the fact that frr is not defined in hardcoded DEFAULT_STANDARD_USERS/DEFAULT_STANDARD_GROUPS or in setup/uidgid file, I still think groupadd for frr should contain '-r' option like it is for frrvty: ~~~ %pre getent group frrvty >/dev/null 2>&1 || groupadd -r frrvty >/dev/null 2>&1 || : getent group frr >/dev/null 2>&1 || groupadd frr >/dev/null 2>&1 || : ~~~ Otherwise, I filled two new BZs for fedora-review regarding the broken link to texinfo scriplet documentation and the other one regarding strange macro expansions for %systemd_*: Bug 1725569 - fedora-review points to non-existent texinfo documentation Bug 1725584 - fedora-review: strange behavior in CheckSystemdUnitdirScriplets() -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component