[Bug 1727491] Review Request: python-lfpy - A module for modeling extracellular potentials of multicompartment neuron models built on NEURON
https://bugzilla.redhat.com/show_bug.cgi?id=1727491
Aymen Qader <qader.aymen(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |qader.aymen(a)gmail.com
--- Comment #5 from Aymen Qader <qader.aymen(a)gmail.com> ---
Hi, I'm not sponsored yet so these are just a few unofficial comments (not a
comprehensive review):
* Your summary is too long -- it shouldn't exceed 79 characters.
* The package doesn't build with mock, you need to list a BuildRequires against
gcc (for cython). Try make sure that the package builds using mock -- check out
https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds
* Move the python3 specific BuildRequires statements to under the python3-
subpackage.
* Make sure that you are not using 'Requires' for dependencies which are only
needed during the build step (e.g. setuptools is likely not required outside of
building, so it should just be a BuildRequires). Likewise, BuildRequires
shouldn't be used for dependencies which are not needed for building but are
needed for the package to function.
* Upstream provides examples, which you can include with %doc. They also
provide sphinx docs, which you can build with sphinx-build and likewise include
with %doc.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component