[Bug 2054599] Review Request: python-specfile - A library for parsing and manipulating RPM spec files
https://bugzilla.redhat.com/show_bug.cgi?id=2054599
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mhroncok(a)redhat.com
--- Comment #2 from Miro Hrončok <mhroncok(a)redhat.com> ---
Spec sanity:
%{?!python3_pkgversion:%global python3_pkgversion 3}
I know of no distribution that has %pyproject_* macros but does not define
%python3_pkgversion. Why do you think this is needed in the spec file? I
believe it should be removed, but maybe I don't have all the information.
%global srcname specfile
(personal opinion) There is no good reason to define this macro. Consider not
doing it. See
https://lists.fedoraproject.org/archives/list/python-devel@lists.fedorapr...
search for "As does Zbyszek,"
%{?python_provide:%python_provide python3-%{srcname}}
This macro is deprecated and does nothing useful. It should be removed.
%license LICENSE
The license file is already included in %{pyproject_files}. It should be
removed.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2054599