https://bugzilla.redhat.com/show_bug.cgi?id=1303411
--- Comment #2 from Petr Pisar <ppisar(a)redhat.com> ---
URL and Source0 and Source1 are usable. Ok.
The source files are original:
378a6305edb9397978e60b7908a85dd8c2546f2808cb845552d5e4a8ba9baab3
*geteltorito.pl
a76f3347f8e2221d9b6550078ac57a0a2c4e8b1da6ce1a1a8aacab93be7e8e23 *gpl.txt
Ok.
TODO: Use as Source0
<
http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/geteltori...
instead of
<
http://userpages.uni-koblenz.de/~krienke/ftp/noarch/geteltorito/geteltori...;.
The files are identical while the former name matches the name you want to
install it under.
FIX: I think the license is "GPL+" because the source code states
"License:
GPL" and the gpl.txt file states "If the Program does not specify a version
number of
this License, you may choose any version ever published by the Free Software
Foundation" in section 9.
FIX: Correct Summary spelling. Either remove the relading "A" or change it into
"An".
FIX: Correct description. The "existant" and "secify" are misspelled.
A comma
is missing in "STDOUT all", in "STDOUT you". The full stop period is
missing at
the end of the description.
FIX: The spec file calls "cp" command. You should build-require
"coreutils".
FIX: Make the package noarch. Neither the Perl script, or the GPL text depend
on an architecture.
$ rpmlint geteltorito.spec ../SRPMS/geteltorito-0.6-1.fc24.src.rpm
../RPMS/x86_64/geteltorito-0.6-1.fc24.x86_64.rpm
geteltorito.spec: W: no-%build-section
geteltorito.src: W: spelling-error %description -l en_US toritoimagefile ->
territoriality
geteltorito.src: W: spelling-error %description -l en_US dev -> deb, derv, div
geteltorito.src: W: spelling-error %description -l en_US tmp -> mp, temp, tamp
geteltorito.src: W: spelling-error %description -l en_US bootimage -> boot
image, boot-image, bootlegged
geteltorito.src: W: spelling-error %description -l en_US perl -> Perl, peel,
perk
geteltorito.src: W: spelling-error %description -l en_US existant -> existent,
exist ant, exist-ant
geteltorito.src: W: spelling-error %description -l en_US bootimages -> boot
images, boot-images, sabotages
geteltorito.src: W: spelling-error %description -l en_US imagedata -> image
data, image-data, imaginative
geteltorito.src: W: spelling-error %description -l en_US eg -> eh, e, g
geteltorito.src: W: spelling-error %description -l en_US secify -> specify,
specif
geteltorito.src: W: spelling-error %description -l en_US filename -> file name,
file-name, filament
geteltorito.src: W: spelling-error %description -l en_US commandline -> command
line, command-line, commandment
geteltorito.src: W: no-%build-section
geteltorito.x86_64: W: spelling-error %description -l en_US toritoimagefile ->
territoriality
geteltorito.x86_64: W: spelling-error %description -l en_US dev -> deb, derv,
div
geteltorito.x86_64: W: spelling-error %description -l en_US tmp -> mp, temp,
tamp
geteltorito.x86_64: W: spelling-error %description -l en_US bootimage -> boot
image, boot-image, bootlegged
geteltorito.x86_64: W: spelling-error %description -l en_US perl -> Perl, peel,
perk
geteltorito.x86_64: W: spelling-error %description -l en_US existant ->
existent, exist ant, exist-ant
geteltorito.x86_64: W: spelling-error %description -l en_US bootimages -> boot
images, boot-images, sabotages
geteltorito.x86_64: W: spelling-error %description -l en_US imagedata -> image
data, image-data, imaginative
geteltorito.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g
geteltorito.x86_64: W: spelling-error %description -l en_US secify -> specify,
specif
geteltorito.x86_64: W: spelling-error %description -l en_US filename -> file
name, file-name, filament
geteltorito.x86_64: W: spelling-error %description -l en_US commandline ->
command line, command-line, commandment
geteltorito.x86_64: E: no-binary
geteltorito.x86_64: W: no-documentation
geteltorito.x86_64: W: no-manual-page-for-binary geteltorito
2 packages and 1 specfiles checked; 1 errors, 28 warnings.
FIX: Correct the spelling.
$ rpm -q -lv -p ../RPMS/x86_64/geteltorito-0.6-1.fc24.x86_64.rpm
-rwxr-xr-x 1 root root 6602 Feb 1 15:34
/usr/bin/geteltorito
drwxr-xr-x 2 root root 0 Feb 1 15:53
/usr/share/licenses/geteltorito
-rw-rw-r-- 1 root root 17996 Feb 1 15:34
/usr/share/licenses/geteltorito/gpl.txt
File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/geteltorito-0.6-1.fc24.x86_64.rpm | sort
-f | uniq -c
1 /usr/bin/perl
1 perl(Getopt::Std)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/x86_64/geteltorito-0.6-1.fc24.x86_64.rpm | sort
-f | uniq -c
1 geteltorito = 0.6-1.fc24
1 geteltorito(x86-64) = 0.6-1.fc24
Binary provides Ok.
$ resolvedeps rawhide ../RPMS/x86_64/geteltorito-0.6-1.fc24.x86_64.rpm
Binary dependencies resolvable. Ok.
Package builds in F24
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=12771616). Ok.
Otherwise the package in line with Fedora and Perl packaging guideline.
Please correct all `FIX' items, condider fixing `TODO' items and provide new
spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component