[Bug 216102] Review Request: python-twisted-conch - Twisted SSHv2 implementation

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-twisted-conch - Twisted SSHv2 implementation https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216102 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |kevin(a)tummy.com OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin(a)tummy.com 2006-12-16 13:51 EST ------- See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 0236162d53cf7f34ed341d9179e7783b TwistedConch-0.7.0.tar.bz2 0236162d53cf7f34ed341d9179e7783b TwistedConch-0.7.0.tar.bz2.1 See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. x86_64/i386 - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: See below - Should build in mock. i386/x86_64 - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Same comment as from the python-twisted-names review about the %{python} macro You will be maintaining these packages so it's your call, but it doesn't do anything useful for this fedora extras spec IMHO. 2. Might add the LICENSE and NEWS files in as %doc? 3. Needs BuildRequires: python-devel for fc7/devel. 4. rpmlint says: E: python-twisted-conch no-binary (which can be ignored in this case) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.