https://bugzilla.redhat.com/show_bug.cgi?id=2033757
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |177841 (FE-NEEDSPONSOR)
--- Comment #5 from Fabio Valentini <decathorpe(a)gmail.com> ---
Looks much better now, thanks!
Minor issues:
- "to show no errors in rpmlint results" is not a valid explanation for making
changes to a package.
rpmlint is known to show many false positive errors, so if you really think
this is a problem, explain the real problem, and not just "rpmlint complains".
Lots of packages install translations for the "mo" locale in Fedora, so this
does not seem to be a problem, but rather an issue in rpmlint, because it
doesn't recognise this locale code. In contrast, the only two Fedora packages
(!) which ship ro_MD locales are elementary-code and elementary-terminal, and
it's probably not a good idea there, either ...
I'd say it would be a better idea to drop the PR / patch for now. Most packages
in Fedora use "mo" locale instead of "ro_MD" (but I think neither are
actually
supported, so it doesn't help to change it, either).
- This package uses %define, it should use %global instead.
Unless there's a very good reason, you should *always* use %global, instead of
%define.
- I recommend not using "sed" for "monkey-patching" files. Instead,
use a real
patch.
Real patches break if the file changes, sed scripts just silently do nothing
when that happens.
- I recommend using rpmautospec for the package, once it is imported. It will
make maintaining the Release field and writing %changelog messages unnecessary
in the future. It is documented here, if you're interested:
https://docs.pagure.org/fedora-infra.rpmautospec/index.html
I'm using it for all other Pantheon-related packages already. You can look at
some of them for how it works.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2033757