https://bugzilla.redhat.com/show_bug.cgi?id=1427085
Damian Wrobel <dwrobel(a)ertelnet.rybnik.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(dwrobel@ertelnet. |
|rybnik.pl) |
--- Comment #7 from Damian Wrobel <dwrobel(a)ertelnet.rybnik.pl> ---
(In reply to Raphael Groner from comment #4)
Sorry for the very long delay here. I had a lot of daily job work to
do.
It's absolutely no problem as the same applies to others as well - I'm
sorry
for the delay.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
MUST fix:
- update-desktop-database is invoked in %post and %postun if package
removed
- Can not completely validate GPLv3+ of source files due to missing
headers,
please poke upstream about those:
upstream updated source files
https://fedoraproject.org/wiki/Packaging:
LicensingGuidelines#Multiple_Licensing_Scenarios
without bundled
qtsingleapplication library it becomes single licensed package
- Remove duplication of folders ownership, see note below.
removed, except %{_datadir}/icons/hicolor/scalable/apps for which I applied:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_package_you_depen...
- Note correct release string in changelog, see rpmling warning.
It's according to
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots.
- Unbundle qtsingleapplication, it's available as a separate
package.
unbundled
SHOULD fix:
- May want to use latest commit for the package. As of now: 7a96d90
packaged the
latest one (includes updated license header)
- Please include README.mime into %doc, it contains useful
information
about mime integration. Even better would be if package can configure that.
it
was already configured in the previous version, thus README.mime migh
confuse user
- Please move appstream-util validate-relax from %install into
%check.
as per
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage
it could be: "(in %check or %install)".
- May be worth to run tests of dedicated subfolder in %check.
I
didn't touch it.
- Please use 'cp -p' to preserve timestamps also for icons
and translations.
I'm using 'cp -a' which is the "same as -dR
--preserve=all".
- Please drop useless /usr/lib/.build-id file, see rpmlint warnings.
Strange, as the package never provided anything in the /usr/lib.
Please find updated spec and SRPM files:
Spec URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/plantumlqeditor....
SRPM URL:
https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/plantumlqeditor-...
(In reply to Raphael Groner from comment #5)
Scratch build in rawhide fails currently, see bug #1427085.
Koji scratch build (rawhide):
https://koji.fedoraproject.org/koji/taskinfo?taskID=19490015
at the time of writing all builds finished successfully except s390x which
seems to got stuck in: "Loading logs for task 19490021....".
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component