[Bug 707617] Review Request: libircclient-qt - Cross-platform IRC client library written with Qt 4

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=707617 Michael Schwendt <mschwendt(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mschwendt(a)gmail.com AssignedTo|nobody(a)fedoraproject.org |mschwendt(a)gmail.com Flag| |fedora-review? --- Comment #1 from Michael Schwendt <mschwendt(a)gmail.com&gt; 2011-07-30 06:49:24 EDT --- * "spectool -g libircclient-qt.spec" fails downloading the tarball. Visiting the web page download area, it seems the correct Source0 location is without the leading 'www.' - download then succeeds: https://bitbucket.org/jpnurmi/libircclient-qt/downloads/%{name}-src-%{ver... As long as we keep filling this Group tag, the correct group for library -devel packages is: Development/Libraries Repeating License and URL tags here is not needed. So, unless you insist on maintaining them in two places, better delete them here. %{?_isa} is missing: https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Which package owns %{_includedir}/ircclient-qt/ and the several directories below %_libdir? https://fedoraproject.org/wiki/Packaging:UnownedDirectories Also, since several essential headers, such as "irc.h" include Qt headers, there's a "Requires: qt-devel" missing in the -devel package. These %doc files are duplicates of the ones installed by the base package. As a result, this only clutters up /usr/share/doc/ where two directories for the libircclient-qt packages would be created. * What about packaging the 'doc' directory with its HTML documentation? * Build log warns about deprecated features being enabled and adds many warnings about individual deprecated items. What's the story here? The 'INSTALL' file comments on that, but doesn't answer when the "deprecated backwards compatible functionality" could be needed. * Build log: compilation is non-verbose. One cannot see the used compiler flags, for example. This is because the QMake project file adds CONFIG += silent. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.