https://bugzilla.redhat.com/show_bug.cgi?id=1773467
Richard W.M. Jones <rjones(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(lnie(a)redhat.com)
--- Comment #6 from Richard W.M. Jones <rjones(a)redhat.com> ---
These Requires in the spec file are all suspicious:
Requires: python3, python3-devel, [...] python3-aexpect
Requires: python3-netaddr, python3-netifaces, python3-simplejson
You shouldn't depend on python3-devel anyway, and the other ones will
be picked up automatically by RPM. Try removing these lines and see
what the automatically generated Requires look like in the final RPM.
This one is OK: "Requires: python3-avocado >= 51.0" because it's
enforcing
a minimum version.
rpmlint complains that several Python libraries have #!/usr/bin/python at
the top of them, which is likely to be wrong (unless these scripts are
intended to be run as separate programs, in which case they are in the wrong
directory and have the wrong permissions too). You may need to use sed or
work with upstream to get these fixed:
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/cartesian_config.py 644
/usr/bin/python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/data_dir.py 644 /usr/bin/python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/postprocess_iozone.py 644
/usr/bin/python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/remote_commander/messenger.py 644
/usr/bin/env python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/remote_commander/remote_master.py 644
/usr/bin/env python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/remote_commander/remote_runner.py 644
/usr/bin/env python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/rss_client.py 644 /usr/bin/python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/staging/utils_cgroup.py 644
/usr/bin/python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/step_editor.py 644 /usr/bin/python
python3-avocado-vt.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/virttest/version.py 644 /usr/bin/python
rpmlint complains about these files using #!/usr/bin/env:
python3-avocado-vt.noarch: E: env-script-interpreter
/usr/share/avocado-plugins-vt/shared/deps/run_autotest/boottool.py /usr/bin/env
python
python3-avocado-vt.noarch: E: non-executable-script
/usr/share/avocado-plugins-vt/shared/scripts/duplicate_pages.py 644
/usr/bin/python
I notice that you're disabling RPM #! mangling (%global
__brp_mangle_shebangs_exclude_from)
but it's unclear why you're doing that?
rpmlint complains that there are C/C++ source files in the package, is there a
reason
for this?
python3-avocado-vt.noarch: W: devel-file-in-non-devel-package
/usr/lib/python3.7/site-packages/virttest/passfd.c
python3-avocado-vt.noarch: W: devel-file-in-non-devel-package
/usr/share/avocado-plugins-vt/shared/deps/finish/finish.cpp
python3-avocado-vt.noarch: W: devel-file-in-non-devel-package
/usr/share/avocado-plugins-vt/shared/deps/rss/rss.cpp
python3-avocado-vt.noarch: W: devel-file-in-non-devel-package
/usr/share/avocado-plugins-vt/shared/deps/rss/rss6.cpp
python3-avocado-vt.noarch: W: devel-file-in-non-devel-package
/usr/share/avocado-plugins-vt/shared/scripts/pipetest.c
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component