https://bugzilla.redhat.com/show_bug.cgi?id=1018859
--- Comment #2 from Petr Pisar <ppisar(a)redhat.com> ---
URL is usable. Ok.
Source0 is usable. Ok.
Source tar ball is original (SHA-256:
007f1cc9c5779fe9b2bacefec8535157ae647499347ffbbea931da63e793f216). Ok.
FIX: The summary is not descriptive. See README or Clui.pm for better text.
Description verified from Clui.pm. Ok.
License verified from Clui.pm, Clui/FileSelect.pm, test.pl,
examples/login_shell, examples/test_script, examples/linux_admin,
examples/audio_stuff, examples/choose. The py/test_script is not part of binary
package. Ok.
No XS code. noarch BuildArch is Ok.
TODO: Remove the BuildRoot definition and cleaning in the %install section and
remove the whole %clean section. They are not needed for Fedora.
TODO: You can replace `%{__perl}' macro with plain `perl' command.
TODO: You can replace PERL_INSTALL_ROOT argument with standard DESTDIR argument
in the %install section.
TODO: You can remove deleting empty directories in the %install section.
ExtUtils::MakeMaker does not create empty directories anymore.
FIX: Remove %defattr macro from %files section. This is not needed anymore
(since rpm-4.4).
TODO: You could package the `example' subdirectory as a documentation.
FIX: Build-require `perl(Exporter)' (Clui.pm:13).
TODO: Build-require `perl(strict)' (Clui.pm:20).
TODO: Build-require `perl(warnings)' (Clui.pm:20).
The Term::ReadKey, Term::ReadLine::Gnu, Term::Size modules are recommended. Ok.
All tests pass. Ok.
$ rpmlint perl-Term-Clui.spec ../SRPMS/perl-Term-Clui-1.68-1.fc21.src.rpm
../RPMS/noarch/perl-Term-Clui-1.68-1.fc21.noarch.rpm
perl-Term-Clui.src: W: spelling-error %description -l en_US summarised ->
summarized, summarize
perl-Term-Clui.src: W: spelling-error %description -l en_US pgp -> pg, pp, pep
perl-Term-Clui.src: W: spelling-error %description -l en_US rcs -> rs, cs, arcs
perl-Term-Clui.noarch: W: spelling-error %description -l en_US summarised ->
summarized, summarize
perl-Term-Clui.noarch: W: spelling-error %description -l en_US pgp -> pg, pp,
pep
perl-Term-Clui.noarch: W: spelling-error %description -l en_US rcs -> rs, cs,
arcs
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Term-Clui-1.68-1.fc21.noarch.rpm
drwxr-xr-x 2 root root 0 Oct 16 12:46
/usr/share/doc/perl-Term-Clui
-rw-r--r-- 1 root root 3848 Jul 3 02:59
/usr/share/doc/perl-Term-Clui/Changes
-rw-r--r-- 1 root root 3422 Nov 10 2010
/usr/share/doc/perl-Term-Clui/README
-rw-r--r-- 1 root root 7715 Oct 16 12:46
/usr/share/man/man3/Term::Clui.3pm.gz
-rw-r--r-- 1 root root 3528 Oct 16 12:46
/usr/share/man/man3/Term::Clui::FileSelect.3pm.gz
drwxr-xr-x 2 root root 0 Oct 16 12:46
/usr/share/perl5/vendor_perl/Term
drwxr-xr-x 2 root root 0 Oct 16 12:46
/usr/share/perl5/vendor_perl/Term/Clui
-rw-r--r-- 1 root root 55522 Jul 3 10:48
/usr/share/perl5/vendor_perl/Term/Clui.pm
-rw-r--r-- 1 root root 9843 Mar 23 2013
/usr/share/perl5/vendor_perl/Term/Clui/FileSelect.pm
File layout and permissions is Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Term-Clui-1.68-1.fc21.noarch.rpm |
sort -i | uniq -c
1 perl(Exporter)
1 perl(:MODULE_COMPAT_5.18.1)
1 perl(Term::ReadKey)
1 perl(Term::ReadLine::Gnu)
1 perl(Term::Size)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Run-require `perl(strict)' (Clui.pm:20).
TODO: Run-require `perl(warnings)' (Clui.pm:20).
$ rpm -q --provides -p ../RPMS/noarch/perl-Term-Clui-1.68-1.fc21.noarch.rpm |
sort -i | uniq -c
1 perl(Term::Clui) = 1.68
1 perl-Term-Clui = 1.68-1.fc21
1 perl(Term::Clui::FileSelect) = 1.68
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Term-Clui-1.68-1.fc21.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F21
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=6064821). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct all `FIX' items, consider fixing `TODO' items, and provide new
SPEC file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.