[Bug 433547] Review Request: nagios-nsca - nagios passive check daemon

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nagios-nsca - nagios passive check daemon https://bugzilla.redhat.com/show_bug.cgi?id=433547 ------- Additional Comments From xavier(a)bachelot.org 2008-03-10 14:45 EST ------- + source files match upstream: 33a98e7975f633a9489d7a8938ed6131 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + package builds in mock ( ). + package installs properly + debuginfo package looks complete. + rpmlint is not silent, but the 2 warnings are expected : nsca.i386: E: non-readable /etc/nagios/nsca.cfg 0600 nsca-client.i386: E: non-readable /etc/nagios/send_nsca.cfg 0600 + final provides and requires are sane: Provides: config(nsca) = 2.7.2-4.el5 Requires(interp): /bin/sh /bin/sh /bin/sh Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires(post): /bin/sh /sbin/chkconfig Requires(preun): /bin/sh /sbin/chkconfig /sbin/service Requires(postun): /bin/sh /sbin/service Requires: /bin/sh config(nsca) = 2.7.2-4.el5 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIB C_2.4) libmcrypt.so.4 libnsl.so.1 nagios rtld(GNU_HASH) Provides: config(nsca-client) = 2.7.2-4.el5 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: config(nsca-client) = 2.7.2-4.el5 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libmcrypt.so.4 libnsl.so.1 rtld(GNU_HASH) + no shared libraries are added to the regular linker search paths. - owns the directories it creates. nsca-client should own /etc/nagios because it doesn't require nagios. nsca doesn't because it requires nagios. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + scriptlets follow guidelines. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. just add %dir %{_sysconfdir}/nagios for the client and it should be good to go. additional note : nsca-2.7.2-initreload.patch might need to be renamed now it does more than just add reload to the init script. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.