https://bugzilla.redhat.com/show_bug.cgi?id=1427085
--- Comment #9 from Raphael Groner <projects.rg(a)smart.ms> ---
Thanks for your fixes, but there is still a need of some important comments …
> MUST fix:
> - update-desktop-database is invoked in %post and %postun if package
removed
It's not fixed, please try again.
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database
> - Remove duplication of folders ownership, see note below.
removed, except %{_datadir}/icons/hicolor/scalable/apps for which I applied:
https://fedoraproject.org/wiki/Packaging:Guidelines#The_package_you_depen...
Nearly right. Though, you have to remove ownership of
%{_datadir}/icons/hicolor and all subdirectories because it's obviousl owned by
hicolor-icon-theme and 'Requires: hicolor-icon-theme' is sufficient.
>
https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Multiple_Licensing_Scenarios
without bundled qtsingleapplication library it becomes single licensed package
…
> - Unbundle qtsingleapplication, it's available as a separate
package.
unbundled
Try to unbundle gmock and gtest as well, we've also separate packages
of those
both. Sorry, I forgot to mention that.
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplicat...
SHOULD (additionally):
[?]: Package functions as described.
…
[?]: %check is present and all tests pass.
You should run the
tests provided by upstream in %check.
https://github.com/borco/plantumlqeditor/tree/master/tests
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component