[Bug 674080] Review Request: rubygem-acts_as_audited - Ruby extension logging all changes to your models in an audits table

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=674080 Bohuslav Kabrda <bkabrda(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bkabrda(a)redhat.com --- Comment #1 from Bohuslav Kabrda <bkabrda(a)redhat.com&gt; 2011-09-07 04:12:42 EDT --- Unofficial review: * License seems to be wrong - Public Domain should be used. * rpmlint complains about no %prep and %build. I suggest using at least %prep, because if any patches come into play, it would be wise to apply them in %prep. * Consider adding CHANGELOG to %doc. * rpmbuild complains about files being listed twice - README and LICENSE. I don't think this is a very big problem, but it can be solved by excluding them from %{geminstdir} and leaving them only in %doc (same for the CHANGELOG, if you add it to %doc). * Otherwise, everything seems to be ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.