https://bugzilla.redhat.com/show_bug.cgi?id=1992629
--- Comment #4 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
Thank you for the changes,
%description -n python3-%{pkg_name}-tests
Tests for the Oslo Middleware library.
%{common_desc2}
The %{common_desc2} line needs to be removed, the variable isn't
defined now.
- Package must not depend on deprecated() packages.
Note: python3-mock is deprecated, you must not depend on it.
See:
https://docs.fedoraproject.org/en-US/packaging-
guidelines/deprecating-packages/
BuildRequires: python3-mock
Requires: python3-mock
We should use `unittest.mock` instead. I am looking at the source code
[jkadlcik@zeratul oslo.middleware-5.0.0]$ grep -r mock |grep import
oslo_middleware/tests/test_catch_errors.py:from unittest import mock
oslo_middleware/tests/test_correlation_id.py:from unittest import mock
oslo_middleware/tests/test_healthcheck.py:from unittest import mock
oslo_middleware/tests/test_stats.py:from unittest import mock
And they already use unittest.mock, so I think you can simply remove
the python3-mock dependencies.
The
https://bugs.launchpad.net/oslo.middleware is an issue tracker
URL, which IMHO isn't ideal, I like the
https://launchpad.net/oslo
better. But it isn't a deal breaker for me, use the one you prefer.
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-oslo-middleware , python3-oslo-middleware-tests , python-oslo-
middleware-lang
This one is easy to fix, please take a look here
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_bas...
---
For the record (and for other reviewers)
- If (and only if) the source package includes the text of the
license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file license.png is not marked as %license
I have no idea why fedora-review complains about this, I couldn't find
any license.png anywhere.
[ ]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
Same here, I didn't find any font files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1992629