[Bug 1765730] Review Request: gap-pkg-grpconst - Constructing groups of a given order
https://bugzilla.redhat.com/show_bug.cgi?id=1765730
--- Comment #2 from Jerry James <loganjerry(a)gmail.com> ---
(In reply to Ankur Sinha (FranciscoD) from comment #1)
- I've not been able to find any source files that say GPLv2+.
The GPLv2
license file is included. Could you double check where they say GPLv2 "or
newer" just to be sure that the "+" is needed please?
Oh, sorry, I forgot to mention that that was resolved in git after the 2.6.1
release. This is the justification:
https://github.com/gap-packages/grpconst/commit/b3224915ab870d5ac94ffe61c...
Hopefully upstream releases a new version at some point that includes that
commit.
- incorrect-fsf-address /usr/share/licenses/gap-pkg-grpconst/LICENSE:
Please
let upstream know about this.
Will do.
- Do the Requires need to be versioned? The package's web page
says:
* autpgrp >=1.6
* irredsol >=1.2
Versioning them may help catch issues later when individual packages are
updated.
True. I didn't add the versions because the very first version of autpgrp
built for Fedora was 1.6, and the very first version of irredsol built for
Fedora was 1.3.1, so it is not possible to get older versions from Fedora
repositories, not even for EOL Fedora releases. If those values are updated in
a future release, I will add them to the Requires.
Thanks for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component