[Bug 668823] Review Request: rubygem-text-format - Text::Format formats fixed-width text nicely

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=668823 --- Comment #2 from Mohammed Morsi <mmorsi(a)redhat.com&gt; 2011-02-01 18:39:14 EST --- Thanks alot for the review. Updated the rpm based on feedback: Spec URL: http://mo.morsi.org/files/rpms/rubygem-text-format.spec SRPM URL: http://mo.morsi.org/files/rpms/rubygem-text-format-1.0.0-2.fc14.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2755537 If your taking this official review, please change the status of the bug to 'assigned', assign it to yourself, and change the 'fedora-review' flag to '?' (In reply to comment #1) Done Done Done Please elaborate on this. Which files are wrong? Done. I decoupled this rpm from text-hyphen as it is not a runtime dependency and incase there are issues w/ text-hyphen. Thus I only run the test suite testing the main functionality of this gem, not the one testing it against text-hyphen or other external components. Done Done Since the original gem included these files, and there aren't too many of them, will leave them in the main package. The files are marked as %doc though Fixed These can be ignored. Not seeing these. Fixed Again not seeing some of these. Which rpmlint version are you using. I'm using 0.99, the stock version on F14. Appreciate the feedback. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.