[Bug 1986844] Review Request: ircii - Popular Unix Irc client

https://bugzilla.redhat.com/show_bug.cgi?id=1986844 --- Comment #3 from Gustavo Costa <xfgusta(a)gmail.com&gt; --- * Use http://ircii.warped.com instead of ftp://ircii.warped.com Source0: http://ircii.warped.com/%{name}-%{version}.tar.gz * The make_install macro should be used in the install section %install %make_install * Do not use /usr/bin/irc /usr/bin/irc-20210314 /usr/bin/ircbug /usr/bin/ircflush /usr/libexec/ircio /usr/libexec/wserv use macros like %{_bindir} for /usr/bin and %{_libexecdir} for /usr/libexec instead: %{_bindir}/irc %{_bindir}/irc-%{version} %{_bindir}/ircbug %{_bindir}/ircflush %{_libexecdir}/ircio %{_libexecdir}/wserv You can also use glob instead of listing various files %{_datadir}/irc/* For manpages, you have to use glob: %{_mandir}/man1/irc.1* %{_mandir}/man1/ircII.1* %{_mandir}/man1/ircbug.1* * Do not use the clean section * You have to install the license file %license doc/Copyright --- You can see all these changes here: https://gist.githubusercontent.com/xfgusta/148cc68fdbcfa70d2bc582d404c7f3... Note that there are other things you have to fix, but I don't know how to. ircii.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/irc-20210314 ircii.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/ircflush ircii.x86_64: E: incorrect-fsf-address /usr/bin/ircbug I'm also not sure if openssl and ncurses are required to run ircii, although they are used to build it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component