Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=498147
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2009-04-29 02:02:09 EDT
---
Review:
+ package builds in mock (rawhide i586).
koji Build =>
http://koji.fedoraproject.org/koji/taskinfo?taskID=1327573
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
78d560ad4fb67cb8ceb0d84c4de40ed0 App-Nopaste-0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=8, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.17 cusr 0.01
csys = 0.23 CPU)
+ Package perl-App-Nopaste-0.10-1.fc12.noarch =>
Provides: perl(App::Nopaste) = 0.10 perl(App::Nopaste::Command)
perl(App::Nopaste::Service) perl(App::Nopaste::Service::Gist)
perl(App::Nopaste::Service::Husk) perl(App::Nopaste::Service::Mathbin)
perl(App::Nopaste::Service::PastebinCom) perl(App::Nopaste::Service::Pastie)
perl(App::Nopaste::Service::Rafb) perl(App::Nopaste::Service::Shadowcat)
perl(App::Nopaste::Service::Snitch)
Requires: /usr/bin/env perl(App::Nopaste) perl(App::Nopaste::Command)
perl(Module::Pluggable) perl(Moose) perl(WWW::Mechanize) perl(base)
perl(strict) perl(warnings)
Suggestion:
1) you don't need following
# autoreq doesn't catch this
Requires: perl(MooseX::Getopt)
# necessary for optional modules
Requires: perl(Clipboard)
Requires: perl(Config::INI::Reader)
Requires: perl(Git)
Requires: perl(WWW::Pastebin::PastebinCom::Create)
Requires: perl(WWW::Pastebin::RafbNet::Create)
Remove them and then import new SRPM. I see yum auto processed all these
Requires
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.