https://bugzilla.redhat.com/show_bug.cgi?id=1674278
--- Comment #2 from idf31(a)protonmail.com ---
(In reply to Jaroslav Prokop from comment #1)
I'll do an unofficial review, just some basic points:
* use macros, e.g. %{_bindir}/tty-clock and %{_mandir}/man1/ ...
* I don't think rm -rf buildroot is a way to go and I think there is macro
for it
* Changelog is in an invalid format (or at least not missing a few things)
Please take a look at the guidelines,
https://docs.fedoraproject.org/en-US/packaging-guidelines/
and also take a look at Domain Specific guidelines
https://docs.fedoraproject.org/en-US/packaging-guidelines/
#_domain_specific_guidelines
I'd also recommend running rpmlint on your spec files and rpm packages
before submitting
I wish you good luck and looking forward to your future work!
Hello,
Thank you for your points.
I've manually specified the path because tty-clock would install in
/usr/local/bin/ and not /usr/bin/ (the value for ${_bindir}, same for the man
pages.
Reading the guidelines seem to forbid installation in /usr/local, so what can I
do to make tty-clock install in /usr/bin without modifying the upstream source?
Also I have removed "rm -rf buildroot" from the .spec.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component