[Bug 1397643] Review Request: dapl - Library providing access to the DAT 2.0 API
https://bugzilla.redhat.com/show_bug.cgi?id=1397643
--- Comment #4 from Honggang LI <honli(a)redhat.com> ---
(In reply to Michal Schmidt from comment #3)
Issues:
=======
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/rdma
>>> I would just drop the "--sysconfdir=/etc/rdma" configure option.
I suggest to keep this, as RDMA user-space packages install conf into
/etc/rdma. RHEL (and CENTOS) also use /etc/rdma as conf directory for RDMA
packages. It is more user friendly to keep this. Install conf files in
different directories will confuse Redhat users.
>>> "--enable-ext-type=ib" is the default option - no need to pass it
to
configure.
It is harmless. Anyway I will delete this.
>>> "-fno-strict-aliasing" may be unnecessary. Doug added it in 2009,
but it's
not clear why. Other distros do not add the option.
The build with -Wall -O2 (which together imply -Wstrict-aliasing) does
Confirmed "-fno-strict-aliasing" is no longer needed. Will remove it.
>>> In %description please use "RDMA" spelling consistently. There is
one
occurrence of lower-case "rdma".
sed -e 's/and rdma write with/and RDMA write with/' -i dapl.spec
In "libdat and libdapl provides" use singular form
"provide".
sed -e 's/libdat and libdapl provides/libdat and libdapl provide/' -i dapl.spec
In %description of utils use plural "APIs", not
possessive "API's".
sed -e "s/DAT 2.0 APIs/DAT 2.0 API's/" -i dapl.spec
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/rdma
...
[!]: Package complies to the Packaging Guidelines
>>> Dir ownership issue noted above.
dapl will co-own the /etc/rdma directory.
review]$ diff -Nurp f26-v2/dapl.spec f26-v4/dapl.spec
--- f26-v2/dapl.spec 2016-11-25 18:31:28.473837404 -0500
+++ f26-v4/dapl.spec 2016-11-28 21:45:34.392816584 -0500
@@ -14,9 +14,9 @@ BuildRequires: gcc
# Platforms missing in dapl/udapl/linux/dapl_osd.h
ExcludeArch: s390, armv7hl
%description
-Along with the RDMA kernel drivers, libdat and libdapl provides
-a userspace RDMA API that supports DAT 2.0 specification and IB
-transport extensions for atomic operations and rdma write with
+Along with the RDMA kernel drivers, libdat and libdapl provide
+a user-space RDMA API that supports DAT 2.0 specification and IB
+transport extensions for atomic operations and RDMA write with
immediate data.
%package devel
@@ -42,7 +42,7 @@ Useful test suites to validate the dapl
find . -type f -iname '*.[ch]' -exec chmod a-x '{}' ';'
%build
-%configure CFLAGS="$CFLAGS -fno-strict-aliasing" --enable-ext-type=ib
--sysconfdir=/etc/rdma
+%configure --sysconfdir=/etc/rdma
sed -i
's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g'
libtool
sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
make %{?_smp_mflags} V=1
@@ -59,6 +59,7 @@ rm -f %{buildroot}%{_libdir}/*.la
%{_libdir}/*.so.*
%{_mandir}/man5/*
%config(noreplace) %{_sysconfdir}/rdma/dat.conf
+%dir %{_sysconfdir}/rdma
%doc AUTHORS README ChangeLog README.mcm
%license COPYING LICENSE.txt LICENSE2.txt LICENSE3.txt
@@ -236,4 +237,4 @@ rm -f %{buildroot}%{_libdir}/*.la
- OFED 1.3-alpha, co-exist with DAT 1.2 library package.
* Wed Mar 7 2007 Arlin Davis <ardavis(a)ichips.intel.com> - 2.0.0.pre
-- Initial release of DAT 2.0 APIs, includes IB extensions
+- Initial release of DAT 2.0 API's, includes IB extensions
Spec URL:
http://people.redhat.com/honli/.419dc6a07891d4da7bc03168d5613fcz/dapl.spec
SRPM URL:
http://people.redhat.com/honli/.419dc6a07891d4da7bc03168d5613fcz/dapl-2.1...
Please review updated SPEC and SRPM files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component