https://bugzilla.redhat.com/show_bug.cgi?id=2245786
Aaron Rainbolt <arraybolt3(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Whiteboard| |NotReady
Doc Type|--- |If docs needed, set a value
CC| |arraybolt3(a)gmail.com
--- Comment #2 from Aaron Rainbolt <arraybolt3(a)gmail.com> ---
Unofficial and incomplete initial review of the spec file:
License: Apache License 2.0
This needs to use an SPDX identifier. See
https://docs.fedoraproject.org/en-US/legal/license-field/
Also more often than not, a program isn't really under just one license, but
oftentimes includes code from other projects under various other licenses. Any
files that ultimately end up in the binary RPM in one form or another need to
have their licenses listed here.
%{?python_provide:%python_provide
python%{python3_pkgversion}-xlmmacrodeobfuscator}
Can you replace this with %py_provides somehow? %python_provide was deprecated
even in the 201x-era Python packaging guidelines
(
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/), and
those guidelines are now old and deprecated at this point, so %python_provide
is like **really** deprecated now. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provid...
for how to use %py_provides.
BuildRequires: python%{python3_pkgversion}-devel
I think you need to spell out "python3-devel" here rather than using the macro.
"Every package that uses Python (at runtime and/or build time) and/or installs
Python modules MUST explicitly include BuildRequires: python3-devel in its
.spec file, even if Python is not actually invoked during build time." (From
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_distro...)
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2245786
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...