Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226295
Jon Ciesla <limburgher(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |limburgher(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |limburgher(a)gmail.com
Flag| |fedora-review?
Bug 226295 depends on bug 468255, which changed state.
Bug 468255 Summary: doc files are not in %doc
https://bugzilla.redhat.com/show_bug.cgi?id=468255
What |Old Value |New Value
----------------------------------------------------------------------------
Resolution| |WONTFIX
Status|ASSIGNED |CLOSED
--- Comment #39 from Jon Ciesla <limburgher(a)gmail.com> 2012-04-03 13:53:13 EDT ---
Fresh review:
Good:
- rpmlint checks return:
php-pear.spec: W: patch-not-applied Patch0: php-pear-1.9.4-restcache.patch
A patch is included in your package but was not applied. Refer to the patches
documentation to see what's wrong.
Fix.
php-pear.noarch: W: self-obsoletion php-pear-XML-Util <= 1.2.1 obsoletes
php-pear-XML-Util = 1.2.1-5.fc18
The package obsoletes itself. This is known to cause errors in various tools
and should thus be avoided, usually by using appropriately versioned Obsoletes
and/or Provides and avoiding unversioned ones.
Fix.
php-pear.noarch: E: incorrect-fsf-address
/usr/share/doc/php-pear-1.9.4/LICENSE-Structures_Graph
php-pear.noarch: E: incorrect-fsf-address
/usr/share/pear/data/Structures_Graph/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
Trivial fix.
Same hidden, zerolength and config-not-noreplace as above, still ok.
php-pear.noarch: W: file-not-utf8
/usr/share/doc/pear/XML_Util/examples/example.php
The character encoding of this file is not UTF-8. Consider converting it in
the specfile's %prep section for example using iconv(1).
Fix.
- package meets naming guidelines
- package meets packaging guidelines
- license ( BSD and PHP and LGPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
This is really pretty good, just the self-obsoletion, patch, license address
and encoding. Let me know if you want me to commit any of these fixes.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.