https://bugzilla.redhat.com/show_bug.cgi?id=1826621
--- Comment #4 from Neil Horman <nhorman(a)redhat.com> ---
This srpm isn't properly constructed in how it builds the application
The Makefile makes several targets (specifically deps and build) which calls
the included scripts/deps.sh and scripts/build.sh file
Those script files run several go get commands to pull in go libraries from
their upstream sources which violates the Fedora golang packaging guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_depend...
The deps script needs to not be run. instead of pulling in those golang
libraries, they should be added as dependencies in the spec file:
go get
github.com/Masterminds/glide => BuildRequires:
golang-github-masterminds-glide-devel
go get
github.com/mh-cbon/go-bin-deb => shouldn't be required for Fedora
go get
github.com/mh-cbon/go-bin-rpm => Shouldn't be required for Fedora since
we're already running rpmbuild
You also need to include BuildRequires: go-rpm-macros
That will autogenerate requirements for you in the completed rpm
Note also that your build.sh script uses git to determine the
version/revision/branch/go_version variables. When building an SRPM, you won't
be working from within a git repo, but from a source tarball. As such those
commands will all fail. It may not be fatal, but the resultant binary will not
have proper version information built in.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component