Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=760943
--- Comment #4 from Petr Pisar <ppisar(a)redhat.com> 2012-01-10 09:48:06 EST ---
Source file is original. Ok.
Summary verified from lib/Messaging/Message.pm. Ok.
License verified from README. Ok.
Description verified from lib/Messaging/Message.pm. Ok.
TODO: Remove useless BuildRoot definition, its delete in %install and whole
%clean section. They are no needed anymore.
No XS files or any compiled code, noarch build architecture is Ok.
TODO: Build-require perl(Encode) for tests (t/2serialize.t:6).
TODO: Build-require perl(Exporter) for tests (lib/Messaging/Message.pm:23).
FIX: Build-require perl(Compress::Zlib) for optional tests (t/2serialize.t:11).
FIX: Build-require perl(Directory::Queue) for optional tests (t/2queue.t:47).
FIX: Build-require perl(Directory::Queue::Simple) for optional tests
(t/2queue.t:53).
TODO: Sort Build-Requires lexicographically to make package maintenance easier.
TODO: Remove useless %defattr macro from %files section.
TODO: Do not package useless VERSION file.
All tests pass. Ok.
$ rpmlint perl-Messaging-Message.spec
../SRPMS/perl-Messaging-Message-0.7-1.fc17.src.rpm
../RPMS/noarch/perl-Messaging-Message-0.7-1.fc17.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Messaging-Message-0.7-1.fc17.noarch.rpm
drwxr-xr-x 2 root root 0 Jan 10 15:34
/usr/share/doc/perl-Messaging-Message-0.7
-rw-r--r-- 1 root root 393 Dec 2 14:50
/usr/share/doc/perl-Messaging-Message-0.7/Changes
-rw-r--r-- 1 root root 1692 Nov 21 11:00
/usr/share/doc/perl-Messaging-Message-0.7/README
-rw-r--r-- 1 root root 4 Dec 2 14:50
/usr/share/doc/perl-Messaging-Message-0.7/VERSION
-rw-r--r-- 1 root root 4998 Jan 10 15:34
/usr/share/man/man3/Messaging::Message.3pm.gz
-rw-r--r-- 1 root root 2693 Jan 10 15:34
/usr/share/man/man3/Messaging::Message::Generator.3pm.gz
-rw-r--r-- 1 root root 2120 Jan 10 15:34
/usr/share/man/man3/Messaging::Message::Queue.3pm.gz
-rw-r--r-- 1 root root 2517 Jan 10 15:34
/usr/share/man/man3/Messaging::Message::Queue::DQ.3pm.gz
-rw-r--r-- 1 root root 2489 Jan 10 15:34
/usr/share/man/man3/Messaging::Message::Queue::DQS.3pm.gz
drwxr-xr-x 2 root root 0 Jan 10 15:34
/usr/share/perl5/vendor_perl/Messaging
drwxr-xr-x 2 root root 0 Jan 10 15:34
/usr/share/perl5/vendor_perl/Messaging/Message
-rw-r--r-- 1 root root 23806 Dec 2 14:52
/usr/share/perl5/vendor_perl/Messaging/Message.pm
-rw-r--r-- 1 root root 7359 Dec 2 14:52
/usr/share/perl5/vendor_perl/Messaging/Message/Generator.pm
drwxr-xr-x 2 root root 0 Jan 10 15:34
/usr/share/perl5/vendor_perl/Messaging/Message/Queue
-rw-r--r-- 1 root root 2164 Dec 2 14:52
/usr/share/perl5/vendor_perl/Messaging/Message/Queue.pm
-rw-r--r-- 1 root root 4087 Dec 2 14:52
/usr/share/perl5/vendor_perl/Messaging/Message/Queue/DQ.pm
-rw-r--r-- 1 root root 4057 Dec 2 14:52
/usr/share/perl5/vendor_perl/Messaging/Message/Queue/DQS.pm
File permissions and layout are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Messaging-Message-0.7-1.fc17.noarch.rpm | sort | uniq -c
2 perl(Digest::MD5)
1 perl(Encode)
1 perl(Exporter)
2 perl(JSON)
1 perl(Messaging::Message)
2 perl(MIME::Base64)
1 perl(:MODULE_COMPAT_5.14.2)
2 perl(Params::Validate)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Remove explicit Requires that are auto-detected: perl(Digest::MD5),
perl(JSON), perl(MIME::Base64), perl(Params::Validate)
$ rpm -q --provides -p
../RPMS/noarch/perl-Messaging-Message-0.7-1.fc17.noarch.rpm | sort | uniq -c
1 perl(Messaging::Message) = 0.7
1 perl-Messaging-Message = 0.7-1.fc17
1 perl(Messaging::Message::Generator) = 0.7
1 perl(Messaging::Message::Queue) = 0.7
1 perl(Messaging::Message::Queue::DQ) = 0.7
1 perl(Messaging::Message::Queue::DQS) = 0.7
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-Messaging-Message-0.7-1.fc17.noarch.rpm
Binary dependencies resolvable. Ok.
Because Koji does not work now, I will do scratch build later.
Please correct all `FIX' issues, consider fixing `TODO' items, and provided new
spec file.
Resolution: Package NOT approved.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.