https://bugzilla.redhat.com/show_bug.cgi?id=1645852
--- Comment #6 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Remove the trailing tabs line 69 and 70:
colobot.src:69: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 69)
- Use %find_lang to handle translation
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/cs/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/de/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/fr/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/pl/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/ru/LC_MESSAGES/colobot.mo
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in colobot-
data , colobot-music , colobot-debuginfo , colobot-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: colobot-0.1.11.1-5.fc30.x86_64.rpm
colobot-data-0.1.11.1-5.fc30.noarch.rpm
colobot-music-0.1.11.1-5.fc30.noarch.rpm
colobot-debuginfo-0.1.11.1-5.fc30.x86_64.rpm
colobot-debugsource-0.1.11.1-5.fc30.x86_64.rpm
colobot-0.1.11.1-5.fc30.src.rpm
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/cs/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/de/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/fr/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/pl/LC_MESSAGES/colobot.mo
colobot.x86_64: W: file-not-in-%lang
/usr/share/locale/ru/LC_MESSAGES/colobot.mo
colobot-data.noarch: W: no-documentation
colobot-music.noarch: W: no-documentation
colobot.src:69: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 69)
6 packages and 0 specfiles checked; 0 errors, 8 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component