[Bug 1651397] Review Request: python-efel - Electrophys Feature Extraction Library
https://bugzilla.redhat.com/show_bug.cgi?id=1651397
--- Comment #3 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
(In reply to Luis Segundo from comment #2)
hello Ankur the spec look good, just a small change
Thanks for the review, Luis!
- All build dependencies are listed in BuildRequires, except for any
that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
the "BuildRequires: gcc-c++" can be remove.
I think this is a false positive. The guidelines are now on docs.fp.o, and this
link fedora-review gives does not point to anything related to such an issue
either. So maybe fedora review is not up to date? I'm not sure what it's
pointing to here:
g++ is necessary for this package, otherwise the build fails. Here is a scratch
build that shows this:
https://koji.fedoraproject.org/koji/taskinfo?taskID=31014016
Even using "gcc" instead of "gcc-c++" fails since the build process
cannot find
the g++ compiler:
https://koji.fedoraproject.org/koji/taskinfo?taskID=31014100
Cheers,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component