Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=809633
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #2 from Petr Pisar <ppisar(a)redhat.com> 2012-04-04 04:14:29 EDT ---
The Spec URL is invalid. Using spec file from SRPM.
Source file is original. Ok.
Summary verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
License verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
Description verified from lib/HTML/TreeBuilder/LibXML.pm. Ok.
Source and URL values are usable. Ok.
No XS code, noarch BuildArch is Ok.
TODO: I recommend removing inc directory (bundled modules) and build-require
`perl(inc::Module::Install)' instead of `perl(ExtUtils::MakeMaker)'
(Makefile.PL:1).
TODO: Build-require `perl(base)' because the module can dual-live the future
(lib/HTML/TreeBuilder/LibXML.pm:6,
http://search.cpan.org/~rgarcia/base/).
TODO: Build-require `perl(Data::Dumper)' because the module can dual-live in
the future (t/01_simple.t:5,
http://search.cpan.org/~smueller/Data-Dumper/).
Otherwise build-time dependencies are Ok.
TODO: Remove useless %defattr(-,root,root,-) from %files section.
All tests pass. Ok.
$ rpmlint perl-HTML-TreeBuilder-LibXML.spec
../SRPMS/perl-HTML-TreeBuilder-LibXML-0.16-1.fc18.src.rpm
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.16-1.fc18.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.16-1.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 Apr 4 09:33
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.16
-rw-r--r-- 1 root root 2651 Apr 2 14:29
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.16/Changes
-rw-r--r-- 1 root root 576 Sep 21 2011
/usr/share/doc/perl-HTML-TreeBuilder-LibXML-0.16/README
-rw-r--r-- 1 root root 2471 Apr 4 09:33
/usr/share/man/man3/HTML::TreeBuilder::LibXML.3pm.gz
-rw-r--r-- 1 root root 2045 Apr 4 09:33
/usr/share/man/man3/HTML::TreeBuilder::LibXML::Node.3pm.gz
drwxr-xr-x 2 root root 0 Apr 4 09:33
/usr/share/perl5/vendor_perl/HTML
drwxr-xr-x 2 root root 0 Apr 4 09:33
/usr/share/perl5/vendor_perl/HTML/TreeBuilder
drwxr-xr-x 2 root root 0 Apr 4 09:33
/usr/share/perl5/vendor_perl/HTML/TreeBuilder/LibXML
-rw-r--r-- 1 root root 4083 Apr 2 14:30
/usr/share/perl5/vendor_perl/HTML/TreeBuilder/LibXML.pm
-rw-r--r-- 1 root root 5905 Nov 29 19:20
/usr/share/perl5/vendor_perl/HTML/TreeBuilder/LibXML/Node.pm
File permissions and layout are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.16-1.fc18.noarch.rpm |sort |uniq
-c
1 perl >= 0:5.008001
1 perl(base)
1 perl(Carp)
1 perl(HTML::TreeBuilder::LibXML::Node)
1 perl(HTML::TreeBuilder::XPath) >= 0.14
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(strict)
1 perl(warnings)
1 perl(XML::LibXML)
1 perl(XML::LibXML) >= 1.7
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Remove unversioned `perl(XML::LibXML)' run-time dependency.
$ rpm -q --provides -p
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.16-1.fc18.noarch.rpm |sort |uniq
-c
1 perl(HTML::TreeBuilder::LibXML) = 0.16
1 perl-HTML-TreeBuilder-LibXML = 0.16-1.fc18
1 perl(HTML::TreeBuilder::LibXML::Node)
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-HTML-TreeBuilder-LibXML-0.16-1.fc18.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F18
(
http://koji.fedoraproject.org/koji/taskinfo?taskID=3962594). Ok.
Otherwise package is in line with Fedora and Perl packaging guidelines.
Please consider fixing `TODO' items before building this package.
Resolution: Package APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.