https://bugzilla.redhat.com/show_bug.cgi?id=1487067
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Hello,
- Requires: pkgconfig is not needed
- The Group: tag is not used in Fedora. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- You could use %make_build instead of make %{?_smp_mflags}
- You could use pkgconfig for your BR:
BuildRequires: pkgconfig(bzip2)
BuildRequires: pkgconfig(zlib)
BuildRequires: pkgconfig(openssl)
- You don't need to repeat the following BR for the devel subpackage:
Requires: bzip2-devel
Requires: zlib-devel
Requires: openssl-devel
- Use %{python3_version} instead of $(rpm -q --provides python3 |grep -i
abi|awk '{ print $3 }')
- You must add license.txt in %license for all the subpackages combinaisons:
%files
%license license.txt
%dir %{_pkgdocdir}
%{_pkgdocdir}/*.txt
%{_libdir}/libbotan-%{major_version}.so.*
%{_bindir}/botan
%files devel
%{_includedir}/*
%exclude %{_libdir}/libbotan-%{major_version}.a
%{_libdir}/libbotan-%{major_version}.so
%{_libdir}/pkgconfig/botan-%{major_version}.pc
%files doc
%license license.txt
%dir %{_pkgdocdir}
%{_pkgdocdir}/manual
%files -n python3-%{name}
%license license.txt
%{python3_sitearch}/%{name}2.py
%{python3_sitearch}/__pycache__/*
- There are a couple of relevant rpmlint errors:
botan.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/botan ['$ORIGIN']
See
https://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath for how
to remove Rpath.
python3-botan.x86_64: E: non-executable-script
/usr/lib64/python3.6/site-packages/botan2.py 644 /usr/bin/env python
You need to set this script executable in %install.
Regarding your sponsorship, I can't help you, but you should introduce yourself
on fedora-devel and do some informal reviews of other packages to show
potential sponsors that you understand Fedora Packaging Guidelines.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component