[Bug 1529824] Review Request: awx - AWX, Ansible Management GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1529824
--- Comment #18 from Xavier Bachelot <xavier(a)bachelot.org> ---
According to what I read in the specfile and a bit of correction in the
packages names, I think the list of missing deps in F31 is not that big. The
list might not be fully accurate, but here's what I think is missing and needs
to be packaged:
python3-azure-common
python3-azure-keyvault
python3-azure-nspkg
python3-build
python3-channels
python3-daphne
python3-django-auth-ldap
python3-django-crum
python3-django-extensions
python3-django-oauth-toolkit
python3-django-pglocks
python3-django-polymorphic
python3-django-solo
python3-django-taggit
python3-djangorest-framework-yaml
python3-irc
python3-jaraco-collections
python3-jaraco-itertools
python3-jaraco-logging
python3-jaraco-stream
python3-jaraco-text
python3-pygerduty
python3-logstash
python3-social-auth-app-django
The specfile itself needs some work:
- Specfile should be named awx.spec (or ansible-awx.spec, see below)
- I am not convinced the package should be named ansible-awx. I'd go for plain
awx.
- Use %global rather than %define
- Remove %define debug_package %{nil}
- Remove %define _prefix /opt/awx
- No need to redefine %{_mandir}
- Remove %global __os_install_post %{nil}
- Replace /var/lib, /var/log, /etc/, /usr/bin, /usr/share, etc... by the
corresponding macros
- Reword Summary to actually be helpful
- Full URL for Source0
- Full URL or useful comment for all the other SxurceX
- Why all the %if 0%{el7} ?
- Drop Group: tag
- Drop BuildRoot:
- Drop Vendor:
- Drop Prefix:
- Why disable the rpm dependency generator ?
- Rewrite %description to be useful. Just the Summary: is not enough and is
useless as is anyway, see above.
- Use macros where possible (awx --> %{name}, 8.0.0.0 --> %{version})
- Virtual env is a no go.
- /opt is a no-go.
- "cp %{_sourcedir}/nginx.conf.example ./" and similar lines looks dubious to
me. Timestamp needs to be preserved. Use 'install -p %{sourceX}
/path/to/dest/file' (or at least "cp -a").
- Be consistant in usage of %{buildroot} vs $RPM_BUILD_ROOT. The former is the
preferred form nowadays.
- Make sure all directories deployed are owned by either the package or a
dependency. For example, /var/lib/awx/ is unowned.
- %config should be %config(noreplace).
- Missing %license.
- %changelog entries are both invalid and not very legible:
- Add the release
- Each entry needs at least one description line below the date.
- Add a whiteline between each entry.
- And probably lost more, but addressing at least some of the above should
allow for a clearer view on the remaining fixes...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component