[Bug 483205] Review Request: eclipse-systemtapgui - GUI interface for SystemTap

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483205 Andrew Overholt <overholt(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #16 from Andrew Overholt <overholt(a)redhat.com&gt; 2009-02-05 10:02:38 EDT --- The package looks good. There are just a few small things that need to be taken care of: - the summary should be more generic. Something like: "Eclipse plugins for SystemTap" - the description expand upon the summary. Something like: "Eclipse plugins providing IDE integration and visualization tools for SystemTap" - you need a 1: epoch prefix for the BR: java-devel. It should be >= 1:1.5.0 - this is an upstream issue so it doesn't really affect this review but I don't think the namespace and source tarball should be named "org.eclipse..." if it's not hosted at eclipse.org - add a line in %files for marking the license as documentation: %doc org.eclipse.systemtapgui.systemtap.feature/epl-v10.html - it seems odd to me that there's no BuildRequires on jsch but there is a Requires: jsch - looking in the error log, I see that there are some issues with the plugins' key bindings. These should be fixed but are upstream issues and won't block this review. - it would be nice if we could fix the NPEs that happen when double-clicking on a probe point in the Probe Alias view: java.lang.NullPointerException at org.eclipse.systemtapgui.generic.editor.actions.file.NewFileAction.queryFile(NewFileAction.java:28) at org.eclipse.systemtapgui.generic.editor.actions.file.OpenFileAction.run(OpenFileAction.java:50) at org.eclipse.systemtapgui.systemtap.ide.actions.hidden.ProbeAliasAction.run(ProbeAliasAction.java:97) at org.eclipse.systemtapgui.systemtap.ide.views.ProbeAliasBrowserView$1.doubleClick(ProbeAliasBrowserView.java:71) at [...] Aside from these issues, everything looks good from a packaging standpoint. It won't take much to get this into shape for acceptance into Fedora. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.