https://bugzilla.redhat.com/show_bug.cgi?id=1766157
Cole Robinson <crobinso(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(stefanha(a)redhat.c
| |om)
--- Comment #2 from Cole Robinson <crobinso(a)redhat.com> ---
The package doesn't build in 'mock' because it's missing BuildRequires:
gcc. Do
'mock liburing-0.2-1.src.rpm' to reproduce, there may be other missing build
deps.
* Release should be Release: 1%{?dist} so the .fcXX bits get appended to the
version string
* Source: should be a pointer to the upstream URL that hosts the release. In
this case I think it should be
https://github.com/axboe/liburing/archive/%{name}-%{version}.tar.gz#%{nam...
, the ending weirdness is due to github renaming the archive strangely. You
might need to pass '-n %{name}-%{name}-%{version}' to %setup/%autosetup to tell
it what the extracted archive name is
* The %defattr lines should be removed:
https://pagure.io/packaging-committee/issue/77
* The Group: lines should be removed
* All the BuildRoot and RPM_BUILD_ROOT lines should be removed. %clean should
be removed
* The ./configure line should be replaced with just %configure
* The 'make' call should be %make_build
* The 'make install' call should be %make_install
* The %pre and %post sections can be entirely removed, ldconfig is done
automatically:
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
* The devel package 'Requires: liburing' should instead be: Requires: %{name} =
%{version}-%{release}
* The devel package should also have Requires: pkgconfig
* I think all the %attr usage can be entirely removed, unless they are doing
something that the build system isn't doing.
* The Provides: liburing.so.1 shouldn't be necessary, I'm pretty sure RPM
automatically adds annotations like this
* Replace %setup with %autosetup, which will automatically apply any listed
Patch: in the spec if anything is backported in the future. It's a small
maintenace optimization
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component