https://bugzilla.redhat.com/show_bug.cgi?id=1452649
--- Comment #12 from Richard W.M. Jones <rjones(a)redhat.com> ---
(In reply to Richard W.M. Jones from comment #10)
- Package contains BR: python2-devel or python3-devel
I don't know why fedora-review prints this, but according to the
Python packaging guidelines this is fine.
Fixed by adding BR: python2-devel
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /etc/exabgp/exabgp.conf
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
This is a bug.
This is fixed by removing the duplicate line.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/exabgp
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/exabgp
Probably need to add %dir for this directory.
By the way, in the spec you can use %{_datadir} instead of
%{_prefix}/share.
This is not fixed.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
%defattr isn't required even for RHEL 7, so this should be deleted
unless you're really intending to use this spec file for ancient
versions of RPM.
Not fixed.
[!]: Requires correct, justified where necessary.
It seems as if the exabgp subpackage should have
‘Requires: %{name} = %{version}-%{release}’.
Currently the exabgp package requires ‘config(exabgp)’ which
python-exabgp provides, but that won't be sufficient to pull in the
correct version.
Not fixed.
[ ]: Package complies to the Packaging Guidelines
Possibly, but I still think the not-really-config /etc/exabgp/examples
files should be moved to /usr/lib/exabgp.
Not changed.
[ ]: Final provides and requires are sane (see attachments).
I suspect exabgp should require python-exabgp. The other dependencies
look fine.
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in exabgp
See above.
See above.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component