https://bugzilla.redhat.com/show_bug.cgi?id=823226
Michael Scherer <misc(a)zarb.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |misc(a)zarb.org
--- Comment #1 from Michael Scherer <misc(a)zarb.org> ---
Hi,
a few comment on the spec :
- you should have a -devel subpackage for developpement related files ( .h,
.pc, etc )
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
- I am not sure, but I think there was some discussion regarding the place of
vala files. However, that's not in the policy yet, so I would just suggest to
keep a eye on it
- the package do not compile on rawwhide ( it does on f17 however ). Not sure
why, but you can check with mock.
- the license tag is invalid
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_Licens...
- there is no ldconfig call in %post, and that's kinda required
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
--
You are receiving this mail because:
You are on the CC list for the bug.