https://bugzilla.redhat.com/show_bug.cgi?id=1401276
--- Comment #3 from Iryna Shcherbina <ishcherb(a)redhat.com> ---
Thank you for the changes.
(In reply to Eric Smith from comment #2)
The reason for the for loop that changes the shebang and perms for
only one
file:
1) copied from another spec file that works - if it ain't broke don't fix it
2) future upstream releases might have more files that need this treatment
If you feel strongly about removing the for loop, let me know and I'll take
it out.
Thanks for the explanation. You can keep it as is for future use if needed.
One more thing, the documentation [0] lists a couple of optional dependencies
which are handled silently if not installed. However pygraphviz seems to be
required if you use a `--draw` option, as it raises an error if not installed:
# grako antlr.ebnf --draw --outfile=out.txt
Traceback (most recent call last):
File "/usr/bin/grako", line 9, in <module>
load_entry_point('grako==3.18.0', 'console_scripts',
'grako')()
File "/usr/lib/python3.5/site-packages/grako/tool.py", line 182, in main
from grako import diagrams
File "/usr/lib/python3.5/site-packages/grako/diagrams.py", line 10, in
<module>
import pygraphviz as pgv
ImportError: No module named 'pygraphviz'
Is there a reason not to require it?
Apart from the above question, everything looks good.
[0]
https://bitbucket.org/apalala/grako/annotate/411da520bac9dd730a49ce39d651...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component