[Bug 1663348] Review Request: blogilo - Blogging Client
https://bugzilla.redhat.com/show_bug.cgi?id=1663348
--- Comment #6 from Kevin Kofler <kevin(a)tigcc.ticalc.org> ---
(In reply to Robert-André Mauchin from comment #5)
- Use %bcond_with/%bcond_without for this:
# uncomment to enable bootstrap mode
%global bootstrap 1
%if !0%{?bootstrap}
%global tests 1
%endif
I don't think that this is a requirement, is it? As far as I know, all the
Qt/KDE packages that require bootstrapping use the %global bootstrap 1 idiom
for bootstrapping, so I'd rather be consistent.
- Please don't glob the major soname version to avoid
unintentional soname bump:
%{_kf5_libdir}/libcomposereditorwebengineprivate.so.5*
This is a private library, so why do we care what the soversion is? No other
package uses this library, ever.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component