https://bugzilla.redhat.com/show_bug.cgi?id=1787714
--- Comment #4 from Neal Gompa <ngompa13(a)gmail.com> ---
First pass spec review notes:
%global debug_package %{nil}
This is not acceptable. Some quick tests indicate the reason why you're unable
to generate debuginfo is because you are not setting the build flags from the
distribution as part of the build. Please fix this.
Epoch: 1
Drop this. There has never been a point where this has been in Fedora such that
an Epoch is needed. Moreover, RPM Fusion's version of this package is an older
version, so this will seamlessly upgrade properly.
Requires: (kernel >= 5.6 or wireguard-dkms)
This is not allowed. You cannot describe a dependency that cannot exist in
Fedora. My suggestion here is to use "Requires: kmod(wireguard.ko)".
Provides: wireguard-tools = %{epoch}:%{version}-%{release}
This is pointless and redundant. Remove it.
%setup -q -n wireguard-tools-%{version}
Use "%autosetup -p1" instead.
LDFLAGS="$LDFLAGS -s" RUNSTATEDIR=/run make
I'm not sure what's going on here, but $LDFLAGS isn't defined yet, because
you
don't have a "%set_build_flags" call at the beginning of the %build
section.
Also, %{_rundir} is the macro for RUNSTATEDIR. And why is make at the end
instead of the beginning?
So, then, why isn't this '%make_build LDFLAGS="$LDFLAGS -s"
RUNSTATEDIR=%{_rundir}'?
DESTDIR=%{buildroot} BINDIR=%{_bindir} MANDIR=%{_mandir}
RUNSTATEDIR=/run \
make install
More loopy make calls...? Why isn't this just "%make_install BINDIR=%{_bindir}
MANDIR=%{_mandir} RUNSTATEDIR=%{_rundir}"?
%clean
rm -rf %{buildroot}
Unneeded. RPM does this automatically. Drop it.
%defattr(-,root,root,-)
Drop this. RPM does this automatically since RPM 4.2 days.
%attr(0755, root, root) %{_bindir}/wg
.. [snip] ...
%attr(0644, root, root) %{_mandir}/man8/wg-quick.8*
Drop all the %attr() statements. They're superfluous because RPM is already
using those values by default.
%{!?_licensedir:%global license %doc}
Drop this, it's not needed for anything anymore.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component